ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Yep, needs an outline instead of a shadow when using software rendering, just 
like the other text with shadows.
  
  Another thing is that in my previous attempt at this, I made the shadows 
optional, since there are places where `ActionButtons` are used that don't 
require any additional contrast for the text, such as on the logout screen. So 
it's best to omit them there. You can see how I did that in D16031 
<https://phabricator.kde.org/D16031>, and it might be nice to do it here, too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19364

To: rooty, #vdg, ngraham, filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to