andersonbruce created this revision. andersonbruce added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. andersonbruce requested review of this revision.
REVISION SUMMARY A DNS field was included on the VPN tab in the initial release to match the interface of the underlying NetworkManager plugin. This change removes this field and instead requires the user to use the standard DNS field on the IPv4 and/or IPv6 tabs to enter DNS servers. The import function was changed to insert any DNS servers specified in the incoming config file into the new locations and the export function was changed to output DNS servers from the IPv4 and IPv6 tabs if they are present but for compatibility with connections created with the previous version or with the basic NetworkManager plugin, if the IPv4 and IPv6 tabs do not contain DNS and an (undisplayed) entry on the VPN tab is present it will export from there. This allows a user to update a connection to the new format by simply exporting it, deleting it, and re-importing it. REPOSITORY R116 Plasma Network Management Applet BRANCH RemoveDNSField REVISION DETAIL https://phabricator.kde.org/D18867 AFFECTED FILES libs/editor/connectioneditorbase.cpp vpn/wireguard/wireguard.cpp vpn/wireguard/wireguard.ui vpn/wireguard/wireguardwidget.cpp vpn/wireguard/wireguardwidget.h To: andersonbruce, jgrulich Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
