ognarb added inline comments.

INLINE COMMENTS

> TextField.qml:101
> +        }
> +        icon.name: root.leftAction != null ? root.rightAction.iconName : ""
> +        visible: root.leftAction != null && root.leftAction.visible

@mart I'm not sure if it's the right way to convert the icon from the action to 
the one needed by the toolButton (don't support icon.source)

> kirigamiplugin.cpp:181
> +    //2.7
> +    qmlRegisterType(componentUrl(QStringLiteral("TextField.qml")), uri, 2, 
> 6, "TextField");
> +

@mart Should I use 2.6 or 2.7? I didn't find any information about that version 
I should use.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

Reply via email to