broulik added inline comments.

INLINE COMMENTS

> apol wrote in ComboBox.qml:207
> delegateModel property doesn't exist in QQC2.ComboBox. I was never getting a 
> popup.
> 
> http://doc.qt.io/qt-5/qml-qtquick-controls-combobox-members.html
> 
> Also we didn't use to specify a delegate to the ListView

The docs you were looking at are QQC1.

  Q_PROPERTY(QQmlInstanceModel *delegateModel READ delegateModel NOTIFY 
delegateModelChanged FINAL)``` is in `QtQuick.Templates` `ComboBox`, which this 
thing is.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18189

To: apol, #kirigami, mart
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to