apol added inline comments. INLINE COMMENTS
> davidedmundson wrote in ComboBox.qml:207 > Breaking it down it's this one line that causes major regressions for me > though I can't immediately see why. > > Can you elaborate on what was broken and why you changed it? delegateModel property doesn't exist in QQC2.ComboBox. I was never getting a popup. http://doc.qt.io/qt-5/qml-qtquick-controls-combobox-members.html Also we didn't use to specify a delegate to the ListView REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
