enriquem added inline comments.

INLINE COMMENTS

> jgrulich wrote in fortisslvpnwidget.cpp:201
> I don't understand why you hare check for prevData.value(), but later on you 
> get optFlag from data (not prevData). Still I don't think this is needed at 
> all. I would go back and use your previous approach, because the result will 
> be the same.

You are probably right. Networkmanager-fortisslvpn is probably drawing code 
form other VPN plugins where there can be more flags set. Here, as you say, the 
only relevant flag is NotSaved.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D17834

To: enriquem, jgrulich
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to