enriquem updated this revision to Diff 48701.
enriquem added a comment.

  I implemented all of your comments except one. I created a new VPN setting 
wit nm-connection-editor, and it sets it to 0, that is, to 
NetworkManager::Setting::None. Thus, I believe that part is correct.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17834?vs=48614&id=48701

REVISION DETAIL
  https://phabricator.kde.org/D17834

AFFECTED FILES
  vpn/fortisslvpn/fortisslvpnadvanced.ui
  vpn/fortisslvpn/fortisslvpnauth.cpp
  vpn/fortisslvpn/fortisslvpnauth.ui
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/fortisslvpn/nm-fortisslvpn-service.h

To: enriquem, jgrulich
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to