hein added inline comments. INLINE COMMENTS
> NotificationItem.qml:33 > width: parent.width > - implicitHeight: Math.max(appIconItem.valid || imageItem.nativeWidth > 0 > ? units.iconSizes.large : 0, mainLayout.height) > + implicitHeight: Math.max(appIconItem.valid || imageItem.nativeWidth > 0 > ? units.iconSizes.large : 0, (mainLayout.height + 1.75 * units.smallSpacing)) > // Add 1.75 units.smallSpacing to correct for the topMargin of mainLayout > Adding 1.75 pixels is just too arbitrary (and not an even number, and not scaled by device pixel ratio). > NotificationItem.qml:175 > top: parent.top > + topMargin: units.smallSpacing * 0.75 > left: appIconItem.valid || imageItem.nativeWidth > 0 ? > appIconItem.right : parent.left Fractions of smallSpacing can lead to subpixel positioning causing blurry text. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham Cc: hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
