filipf added a comment.

  But it seems to me like Nate's addressed or is addressing all the pitfalls 
regarding usability. The icons will have more contrast in a newer revision and 
from what I've seen in that diff there's an idea of adding a rectangle at the 
bottom to make the text there nicely legible. All the other textual elements 
seem just fine in my opinion.
  
  Aesthetically perhaps it would be preferable to avoid the outlines around 
text, but if it helps legibility it's fine. Otherwise I don't think there is 
aesthetic degradation here - and if there is, not blurring the wallpaper will 
compensate for it. And the new revision of the icons in particular looks very 
classy.
  
  The consistency argument actually seems like a stronger one here, but I don't 
see why the lock and login screens should necessarily be identical in design. 
You could use the circular icons in the logout and lock screen to help with 
this. The greatest consistency issue is more likely to be the SDDM theme 
disrespecting user customization, which is a different topic altogether.
  
  My opinion doesn't hold much weight, but it seems to me that: there was 
plenty of time to discuss the idea in the respective task, that the current 
project is at the finish line and that the potential objections do not seem 
grave enough to warrant going back to the drawing board, especially if there is 
no  defined proposal as an alternative.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D16031

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

Reply via email to