pstefan added a comment.

  As other have pointed out the shadows for the buttons and username look out 
of place. Do they use the same radius/spread as those of the clock?
  
  I think blur is still needed. If you look at the picture of the snow-y 
landscape the contrast suffers quite a bit because of the noisy background. In 
my mock-up test the smoothing of the blur helped quite in such cases.

INLINE COMMENTS

> UserDelegate.qml:54
> +
> +        width: imageSource.width + 10
> +        height: width

I am not sure the 10px(?) padding are needed. The white circle is already a 
border around the image i.e. it's always shown, no matter the icon used. So 
this background circle is akin to drawing a dark rectangle behind the input 
field and button.

> UserDelegate.qml:58
> +
> +        color: "black"
> +        opacity: 0.5

If we hardcode this color we should use the same color as in the icons or vice 
versa. I used #232627 50% opacity.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: pstefan, broulik, rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to