thsurrel added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in FolderView.qml:1114
> Do we have grodView.model after back clicked? If we do in expanded view 
> (that's when Folder View is embedded in the panel) goingBack will not be 
> performed.

My understanding was that the gridView.model could be undefined only if the 
FolderModel was not ready. But if we navigated into a subfolder and we are 
asking to go back, than the FolderModel had to be up and running already. Could 
be safe to move this 'if' outside the 'else' though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15840

To: thsurrel, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to