bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS
> broulik wrote in devicenotificationsengine.cpp:39 > This potentially breaks applets relying on the structure of that name? Not > sure how big of an issue this is as far as "API promise" we give for > dataengines but perhaps at least keep the `notification` part first The only user I could find is the device notifier, which relies on the contents of the container only for matching, and does not require any specific format for the source name. Preferably we had some API documentation for the dataengines ... > broulik wrote in devicenotificationsengine.h:26 > Unused? yes, leftover from a different approach. > devicenotificationsengine.h:43 > void notify(Solid::ErrorType solidError, const QString& error, const > QString& errorDetails, const QString &udi); > + void clearNotification(const QString &udi); > whitespace. > broulik wrote in ksolidnotify.cpp:152 > Move this into the relevant `case` below, please I considered this and did not because of the early return. All the other `case`s just do a break and have a common return statement (more correctly, an `emit notify(...)`), this one differs. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15892 To: bruns, #frameworks Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
