broulik added a comment.
I think this makes sense
INLINE COMMENTS
> devicenotificationsengine.cpp:39
> {
> - const QString source = QStringLiteral("notification %1").arg(m_id++);
> + const QString source = QStringLiteral("%1 notification").arg(udi);
>
This potentially breaks applets relying on the structure of that name? Not sure
how big of an issue this is as far as "API promise" we give for dataengines but
perhaps at least keep the `notification` part first
> devicenotificationsengine.h:26
> #include <Plasma/DataEngine>
> +#include <QMap>
>
Unused?
> ksolidnotify.cpp:152
> {
> + if ((error == Solid::ErrorType::NoError) && (type ==
> SolidReplyType::Setup)) {
> + emit clearNotification(udi);
Move this into the relevant `case` below, please
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D15892
To: bruns, #frameworks
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
