bruns planned changes to this revision. bruns added inline comments. INLINE COMMENTS
> broulik wrote in bookmarksrunner.cpp:66 > No, four-argument connect: > > connect(this, &..., this, .... > > Though you just connect from `this` anyway, so I guess this isn't needed Hm, just found that auto-disconnect (see @davidedmundson s comment) only works if you provide a context. The context has to be `m_browser` here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15306 To: bruns, #plasma Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
