davidedmundson added inline comments.

INLINE COMMENTS

> bookmarksrunner.cpp:65
> +    if (m_browser != browser) {
> +        m_browser = browser;
> +        connect(this, &Plasma::AbstractRunner::teardown, [this]() { 
> m_browser->teardown(); });

do we not also need a disconnect on m_browser?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15306

To: bruns, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to