gladhorn added inline comments.
INLINE COMMENTS
> romangg wrote in serializertest.cpp:163
> Below we do some tests in regards to the current config id value. These tests
> are unrelated to any changes of the config id value over time. Therefore it
> should not reference the magic config id value.
>
> Replace the above two lines with:
>
> auto configId = Serializer::configId(config);
>
> // check that this config id value is unchanged from previous versions of
> this software
> QCOMPARE(configId, QLatin1String("8684e883209d7644eb76feea2081c431");
>
> Rest below unchanged in this function. Same in additions to function
> testRotatedScreenConfig.
I was hoping the comment above is enough, repeated explanations are not that
sensible either in my opinion. I need the constant configId to compare against
it later, the point is to confirm that the configId is independent of the order
of outputs in the hash for example.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14364
To: gladhorn, #plasma, romangg
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
