romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> serializertest.cpp:127
> QCOMPARE(screen->currentSize(), QSize(1920, 1280));
> + QCOMPARE(Serializer::configId(config),
> QLatin1String("229fa9e8a378cb151d7302df42666774"));
> }
How did you find this config id and the one below out? Pls add a comment how
these magic numbers relate to the json files and how you obtained them from the
json files.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14364
To: gladhorn, #plasma, romangg
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
