gregormi updated this revision to Diff 35172. gregormi added a comment.
> The text should use title case: "Kill a Window" DONE > The parentheses look a bit ugly, in normal menus the shortcuts are simply aligned to the right (not sure how that's done, though). DONE: align the shortcut strings to the right using \t > At least for Run Command the shortcut should be shown (just like in the desktop context menu) DONE: Add shortcut to 'Run Command' item > The shortcut does not get localized. (In the global shortcuts KCM, it is localized correctly for me.) DONE: using QKeySequence::NativeText; tested with "export LANGUAGE=de_DE" Remove seemingly useless 'class KGlobalAccel' REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10297?vs=34204&id=35172 BRANCH arcpatch-D10297_2 REVISION DETAIL https://phabricator.kde.org/D10297 AFFECTED FILES CMakeLists.txt processui/CMakeLists.txt processui/ProcessWidgetUI.ui processui/ksysguardprocesslist.cpp To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
