rkflx added a comment.
Great, looking much better than before. As far as I can see the inline comments are done. In D10297#229850 <https://phabricator.kde.org/D10297#229850>, @rkflx wrote: > - The text should use title case: "Kill a Window" Not done. > - The shortcut does not get localized. (In the global shortcuts KCM, it is localized correctly for me.) > - The parentheses look a bit ugly, in normal menus the shortcuts are simply aligned to the right (not sure how that's done, though). > - At least for Run Command the shortcut should be shown (just like in the desktop context menu). Are those points impossible to achieve? At least in other places they seem to work… INLINE COMMENTS > gregormi wrote in ksysguardprocesslist.cpp:412 > Interesting. This indeed returns "org.kde.ksysguard". Do you have an idea, > how Qt knows this desktop name? The only occurrences of this string in the > ksysguard project are: > > - gui/CMakeLists.txt: install( PROGRAMS org.kde.ksysguard.desktop > DESTINATION ${KDE_INSTALL_APPDIR} ) > - and gui/org.kde.ksysguard.desktop itself. Interesting question ;) After looking into Qt's sources for `desktopFileName` <https://code.woboq.org/qt5/qtbase/src/gui/kernel/qguiapplication.cpp.html#_ZN15QGuiApplication15desktopFileNameEv>, I set a breakpoint on `QGuiApplication::setDesktopFileName`, and ended up in `KAboutData::setApplicationData` <https://code.woboq.org/qt5/kf5/kcoreaddons/src/lib/kaboutdata.cpp.html#_ZN10KAboutData18setApplicationDataERKS_>. In `ksysguard.cpp` you then have KAboutData aboutData( QStringLiteral("ksysguard"), … … QStringLiteral("ksysguard")aboutData.setOrganizationDomain(QByteArray("kde.org")); …which looks related (did not check in detail, though). REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
