sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS
> davidedmundson wrote in WidgetExplorer.qml:275 > This is all a bit weird. > > This searchBarContainer is 0 px tall as it's not set to be the size of the > children. which is why you need to do that topMargin: units.largeSpacing * > 1.5 bodge later instead of just anchoring to the bottom of this container. > > Also this shouldn't have a fixed size, if it's intended to fill the width of > the parent, tell it to fill the width of the parent. > > You can solve all 3 in one by merging searchBarContainer and searchInput into > just being the one item. I think this is the kind of thing you were looking for. Sizes and spacing based off existing elements rather than explicit sizes. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
