davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > WidgetExplorer.qml:275 > + // full width borrowed from panel definition > + width: Math.max(heading.paintedWidth, > units.iconSizes.enormous * 2 + units.smallSpacing * 4 + units.gridUnit * 2) > + This is all a bit weird. This searchBarContainer is 0 px tall as it's not set to be the size of the children. which is why you need to do that topMargin: units.largeSpacing * 1.5 bodge later instead of just anchoring to the bottom of this container. Also this shouldn't have a fixed size, if it's intended to fill the width of the parent, tell it to fill the width of the parent. You can solve all 3 in one by merging searchBarContainer and searchInput into just being the one item. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
