ngraham added inline comments.

INLINE COMMENTS

> WidgetExplorer.qml:235
> +                } else {
> +                     newSearchRow.height = units.gridUnit * 2
>              }

`units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way 
we can derive this height value programmatically?

> WidgetExplorer.qml:264
> +
> +           // height: 0
> +            visible: heading.showingSearch

Delete code, don't comment it out.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

Reply via email to