mart added inline comments. INLINE COMMENTS
> davidedmundson wrote in AbstractCard.qml:69 > The following should behave the same and it keeps all the semantic meaning > and it means data flows in the right directions > > implicitHeight: mainLayout.implicitHeight + topPadding + bottomPadding > height: internal.completed && internal.gridView > ? internal.gridView.cellHeight - Kirigami.Units.largeSpacing*2 : > implicitHeight > > (not tested as I have an error running the gallery, see IRC) seems to behave the same, but with it i have a binding loop on implicitHeight now REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11316 To: mart, #kirigami, davidedmundson Cc: ngraham, davidedmundson, progwolff, plasma-devel, apol, mart, hein
