graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS > davidedmundson wrote in egl_gbm_backend.cpp:107 > this is going to crash and burn when you have KHR but not Mesa. > > You'll need to keep track of which extension you have, and alter any > extension specific code accordingly. which could be as easy as setting a local variable GLenum platform = hasMesaGBM ? EGL_PLATFORM_GBM_MESA : EGL_PLATFORM_GBM_KHR and use this in the eglGetPlatformDisplayEXT call without all the if-else. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10346 To: mart, #kwin, #plasma, davidedmundson, graesslin Cc: graesslin, garg, davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
