davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> egl_gbm_backend.cpp:107
>  
>          display = eglGetPlatformDisplayEXT(EGL_PLATFORM_GBM_MESA, device, 
> nullptr);
>      }

this is going to crash and burn when you have KHR but not Mesa.

You'll need to keep track of which extension you have, and alter any extension 
specific code accordingly.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10346

To: mart, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

Reply via email to