davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in Module.cpp:145
> Did you check how it behaves with a distro-provided pixmap? I fear it would 
> become tiny. I don't think we have any kind of `@2x` support for that

once you have UseHighDpiPixmaps you won't need this code, Qt will do it 
automatically, including handling your pixmap case.

> broulik wrote in main.cpp:40
> Shouldn't it be `Qt::AA_UseHighDpiPixmaps`?
> 
> From what I understood the `Qt::AA_EnableHighDpiScaling` flag forces high dpi 
> support regardless of environment variables or platform theme.

also it would need to be called before the QApplication constructor

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D10357

To: ngraham, #plasma
Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to