broulik added inline comments.
INLINE COMMENTS
> Module.cpp:145
> } else {
> logo = QPixmap(logoPath);
> }
Did you check how it behaves with a distro-provided pixmap? I fear it would
become tiny. I don't think we have any kind of `@2x` support for that
> main.cpp:2
>
> +
> /*
Unrelated
> main.cpp:40
> {
> + QGuiApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
> KLocalizedString::setApplicationDomain("kinfocenter");
Shouldn't it be `Qt::AA_UseHighDpiPixmaps`?
>From what I understood the `Qt::AA_EnableHighDpiScaling` flag forces high dpi
>support regardless of environment variables or platform theme.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D10357
To: ngraham, #plasma
Cc: broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
