graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma.
INLINE COMMENTS > slide_config.h:36 > +public: > + explicit SlideEffectConfig(QWidget *parent = 0, const QVariantList& args > = QVariantList()); > + ~SlideEffectConfig(); just a minor thingy: please use nullptr instead of 0 in new code. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9382 To: zzag, #kwin, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart