graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS > slide.cpp:31-32 > > +const int DEFAULT_SLIDE_DURATION = 250; > + > SlideEffect::SlideEffect() I don't think that's needed > slide.cpp:55-59 > + int d = SlideConfig::duration(); > + if (!d) > + d = DEFAULT_SLIDE_DURATION; > + > + mTimeLine.setDuration(animationTime(d)); The pattern from other effects would be: const auto duration = animationTime(SlideConfig::duration() != 0 ? SlideConfig::duration() : 250); > slide.cpp:297 > } // namespace > - Please keep this new line > slide_config.ui:36 > + <property name="specialValueText"> > + <string comment="Duration of rotation">Default</string> > + </property> It's not a rotation REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9382 To: zzag, #kwin, #plasma Cc: graesslin, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
