cfeck added a comment.
Please clarify. If https://phabricator.kde.org/D8791 gets accepted, which issues remain that would justify a custom dialog? INLINE COMMENTS > mountdialog.cpp:33 > + m_ui.errorLabelStatic->setVisible(false); > + m_ui.vaultName->setText(QString(" \"%1\"").arg(vault->name())); > +} Is the leasing space intended? > mountdialog.h:2 > +/* > + * Copyright 2017 by cryptod...@libertymail.net > + * Add full name. > mountdialog.h:26 > + > +#include <ui_mountdialog.h> > + #include "ui_mountdialog.h" > mountdialog.h:38 > +protected: > + void accept(); > + override > mountdialog.ui:14 > + <property name="windowTitle"> > + <string>Dialog</string> > + </property> Adjust or remove windowTitle. > mountdialog.ui:47 > + <item> > + <widget class="QLineEdit" name="password"> > + <property name="echoMode"> Please use KPasswordLineEdit REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8787 To: cryptodude, #plasma, ivan Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
