hein added inline comments.

INLINE COMMENTS

> foldermodel.cpp:1122
> +            if (targetUrl.toString().startsWith(url.toString())) {
> +                m_screenMapper->addMapping(targetUrl.toString(), m_screen, 
> ScreenMapper::DelayedSignal);
> +            } else if 
> (targetUrl.toString().startsWith(dropTargetUrl.toString())) {

The code in this patch doesn't test for m_screenMapper being set. I don't think 
FolderModel should require one to work.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8850

To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to