mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
lgtm in general, but a unit test for the positioner would be good to have
INLINE COMMENTS
> foldermodel.cpp:1053
> + if (isDropBetweenSharedViews(mimeData->urls(), dropTargetFolderUrl))
> {
> + /* QMimeData operates on local URLs, but the dir lister and thus
> screen mapper and positioner may
> + * use a fancy scheme like desktop:/ instead. Ensure we always use
> the latter to properly map URLs,
broken indent
> positioner.cpp:403
> + // find the next blank space
> + while (!isBlank(to) && from != to) {
> + to++;
can we get a unit test for this?
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8850
To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
