leinir added a comment.
In https://phabricator.kde.org/D6191#116635, @apol wrote: > In https://phabricator.kde.org/D6191#116531, @leinir wrote: > > > In https://phabricator.kde.org/D6191#116480, @apol wrote: > > > > > This will go to Plasma/5.10, right? > > > > > > As in, merge this patch into Plasma/5.10 as well as master? I don't see why it would fail to merge, yeah, i'll do that :) > > > It went to master, right? Also for some reason it didn't close the bug... It went to master, yeah - as for not closing the bug, it turns out there's an issue matching my commit account to bugzilla... long standing and apparently unsolvable, because... reasons, i guess, tried to get it sorted a while ago. However, i am also now not entirely certain this patch fixes that particular issue - i'll have to have a look, but yeah, not sure. Those particular duplicates aren't KNS entries, so if this patch were to fix it, it would need to go through the resourceRemoved signal catch here. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D6191 To: leinir, apol, #discover_software_store Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
