apol added a comment.
Can you maybe extend the knsbackendtest to make sure we won't regress this?
Thanks a lot!!!
INLINE COMMENTS
> KNSBackend.cpp:109
> m_engine->init(m_name);
> + /// FIXME Set knscore's engine page size to 100 when we can depend on a
> new enough frameworks
> + // m_engine->setPageSize(100);
Add an `#if KNEWSTUFF_VERSION_MAJOR==5 && KNEWSTUFF_VERSION_MINOR==36`
We always end up forgetting these fixme
> KNSBackend.cpp:130
> + // from the model, as they will be added again...
> + foreach(AbstractResource* res, m_resourcesByName.values()) {
> + resourceRemoved(res);
Good, maybe we should also delete them?
Can you see if the StandardUpdater is listening to resourceRemoved?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D6191
To: leinir, apol, #discover_software_store
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
