> On Ян. 28, 2017, 10:47 преди обяд, Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, line 362 > > <https://git.reviewboard.kde.org/r/129872/diff/4/?file=490730#file490730line362> > > > > I don't understand why the group is changed here? Was if wrong before? > > How was it wrong?
It does not present at all in defaults, this group present in kwinrc, but we dont read from it. Please see in *Blocks* pushed reviews. I will update the description. > On Ян. 28, 2017, 10:47 преди обяд, Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, line 246 > > <https://git.reviewboard.kde.org/r/129872/diff/4/?file=490730#file490730line246> > > > > what about theme? I will check that, but in kwinrc does not have theme. > On Ян. 28, 2017, 10:47 преди обяд, Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, lines 670-674 > > <https://git.reviewboard.kde.org/r/129872/diff/4/?file=490730#file490730line670> > > > > If this is no longer needed, why put it together with an unrelated > > change? I do not understaind, this call is not needed because it present later. > On Ян. 28, 2017, 10:47 преди обяд, Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, lines 765-772 > > <https://git.reviewboard.kde.org/r/129872/diff/4/?file=490730#file490730line765> > > > > what is this method for? Your change has no call to it It's maded to be called from qml like applyDesktopSwitcher for example. > On Ян. 28, 2017, 10:47 преди обяд, Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, lines 774-777 > > <https://git.reviewboard.kde.org/r/129872/diff/4/?file=490730#file490730line774> > > > > what is this method for, your change nowhere calls it? Same as above. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102292 ----------------------------------------------------------- On Ян. 28, 2017, 9:35 преди обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129872/ > ----------------------------------------------------------- > > (Updated Ян. 28, 2017, 9:35 преди обяд) > > > Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco > Martin. > > > Repository: plasma-desktop > > > Description > ------- > > ^^ > > > Diffs > ----- > > kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f > kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de > kcms/lookandfeel/kcm.h c27b7f3d > kcms/lookandfeel/kcm.cpp 6ea3d050 > > Diff: https://git.reviewboard.kde.org/r/129872/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
