----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102285 -----------------------------------------------------------
I'm sorry, but this looks rather badly rebased. You deleted code, you shuffled code around, you broke things by reading from the wrong group. I do not understand the change and reading the review it looks like Marco does neither. Please clean up to what you actually want to change and please add a description which explains what it does and not something based on an older idea. kcms/lookandfeel/kcm.h (line 151) <https://git.reviewboard.kde.org/r/129872/#comment68270> why move this line? kcms/lookandfeel/kcm.cpp (line 72) <https://git.reviewboard.kde.org/r/129872/#comment68271> why move this line? kcms/lookandfeel/kcm.cpp (lines 244 - 246) <https://git.reviewboard.kde.org/r/129872/#comment68272> this is not reading the default settings. Also theme is missing kcms/lookandfeel/kcm.cpp (line 362) <https://git.reviewboard.kde.org/r/129872/#comment68273> this is reading the wrong group kcms/lookandfeel/kcm.cpp <https://git.reviewboard.kde.org/r/129872/#comment68274> why remove the dbus call? kcms/lookandfeel/kcm.cpp <https://git.reviewboard.kde.org/r/129872/#comment68275> why remove empty line? - Martin Gräßlin On Jan. 24, 2017, 9 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129872/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 9 p.m.) > > > Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco > Martin. > > > Repository: plasma-desktop > > > Description > ------- > > ^^ > > > Diffs > ----- > > kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f > kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de > kcms/lookandfeel/kcm.h c27b7f3d > kcms/lookandfeel/kcm.cpp 6ea3d050 > > Diff: https://git.reviewboard.kde.org/r/129872/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
