broulik added a comment.
Sorry for being late to the party
INLINE COMMENTS
> DashboardRepresentation.qml:102
> + if (tabBar.activeTab == 1 /* Widgets */ || tabBar.hoveredTab == 1) {
> + root.widgetExplorer = widgetExplorerComponent.createObject(root);
> + root.widgetExplorer.containment =
> containmentInterface.screenContainment(plasmoid);
Would it help if you pass the containment to the createObject call to avoid
some re-evaluation?
root.widgetExplorer = widgetExplorerComponent.createObject(root, {
containment: containmentInterface.screenContainment(plasmoid)
})
> containmentinterface.h:53
> + static Q_INVOKABLE bool screenContainmentMutable(QObject
> *appletInterface);
> + static Q_INVOKABLE void ensureMutable(Plasma::Containment
> *containment);
>
Note that you cannot unlock widgets if kiosk restrictions (SystemImmutable)
apply in which case this entire feature should be disabled or else you open a
neat way for users to screw with a locked-down desktop.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3200
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, mart
Cc: broulik, davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas
