mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > hein wrote in DashboardRepresentation.qml:527 > Good point, what style do you suggest? to be done in a separate commit, but to me it suggests a state machine should be used. even with just two states, but opacity, z and enabled would be PropertyChanges and opacity would have a transition set on it > hein wrote in containmentinterface.h:52 > Mostly because the Widget Explorer model takes a containment assignment to > work, and I don't know what that code does (or will do in the future) if > passed an immutable containment, so it seemed safer. ok REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3200 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
