antlarr added inline comments.
INLINE COMMENTS
> luebking wrote in composite.h:242
> m_testedFrames or similar, "Frame Count" is too generic.
> Alternatively, just use some "int m_freezeDectionFrames = 30;" and count
> them down (so when < 1, you're done)
ok. @graesslin do you prefer a count down or a count up and max? In any case,
I agree with changing the name.
> luebking wrote in platform.h:148
> Have a PreFirstFrame still and make PostLastFrame PostLastGuardedFrame or
> similar. ("Last frame" is right before kwin shuts down ;-)
There's no need for PreFirstFrame, PreFrame is the same for the first or for
the rest of "Pre" cases. But for the PostLastGuardedFrame note I agree. I'll
change that.
> luebking wrote in x11_platform.cpp:215
> Why do you recreate it with every frame?
> Only create it PreFirstFrame and delete it PostLastFrame (and inbeteween
> simply restart the pointer PreFrame)
The timer is in another thread, so it can't be stopped/restarted from this
thread.
> luebking wrote in x11_platform.cpp:224
> same goes for config writing
The config is not written in every frame. It's only saved when the timer is
triggered. That is, when a freeze is detected. That was the point of the
"remove overhead" commit.
REVISION DETAIL
https://phabricator.kde.org/D3132
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas
