davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.
> Can you please summarize all this into a concrete change request for this
patch so it can proceed?
I'm saying it "should" be
delegate:
FrameSvgItem {
prefix: "viewitem/normal"
Item {
//content here, with the margins set to the frame above
}
}
That way if a theme does have a viewitem/normal it gets rendered.
However, if you want you can merge this as-is and I'll start a ML discussion
trying to unify all the delegates.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2089
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
