hein added inline comments. INLINE COMMENTS
> hein wrote in main.qml:70 > We use this same technique in Kicker and FV and other places. It's the only > way to get element sizes from a themer and cope with themes that miss certain > elements. I have asked for better APIs over the years and got a "no" back > from Marco every time. This works, and anything else breaks for the user. Our > UIs rely on it. Oh the Math.max() is because the margin sizes differ for some themes and this avoids ui jumps in cases like that -- another real world fix ... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2089 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc: davidedmundson, broulik, plasma-devel, jensreuterberg, abetts, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel