> On June 19, 2016, 10:35 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/DoublePlotter.qml, lines 82-85 > > <https://git.reviewboard.kde.org/r/128136/diff/4/?file=469010#file469010line82> > > > > This needs fixing. > > > > you've set a right anchors > > you don't have a left anchor > > > > which means the text can be whatever width it wants, and for a long > > label will just overflow everywhere. > > the "wrapMode" will do nothing, as the box is as big as it wants anyway. > > > > For text, it's better to imagine like you're positioning a TextBox in > > inkscape. You draw the maximum size the text can be, then align the text > > within that box. > > > > Aligning the text within the box is done by the horizontalAlignment > > property that was there before: > > http://doc.qt.io/qt-5/qml-qtquick-text.html#horizontalAlignment-prop
and then ship it! - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96732 ----------------------------------------------------------- On June 16, 2016, 12:14 p.m., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128136/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 12:14 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > 1. change the minimum size and the min width in the panel > 2. speedLabels are now right align to the label cause you show the number > which is drown on the right part of the diagramm > 3. round to 14 % instead of 14,14 % for cpu load > > still missing: > a. hide the heading if the desktop widget has to less space for the rows > b. better friendlyName for ram, network > c. remove the gray line from the chart (0-line) at least when the applet was > shown on the panel > d. don't show 0 KB/s or 0 B, ... > > shedule > thanks for your review > if you know how I can fix one of the missing things, let me know > tiny improvements when missing stuff is finished. > > > Diffs > ----- > > applets/systemmonitor/common/contents/ui/Applet.qml fffd8e0 > applets/systemmonitor/common/contents/ui/DoublePlotter.qml 738ffbc > applets/systemmonitor/common/contents/ui/SinglePlotter.qml 987fd2c > applets/systemmonitor/cpu/contents/ui/cpu.qml 4ebbf92 > applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml 994336f > > Diff: https://git.reviewboard.kde.org/r/128136/diff/ > > > Testing > ------- > > on the desktop and the panel > > > File Attachments > ---------------- > > screenshot of the result > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/4fecb3bc-d540-4358-af1d-342c77b9cfa3__Screenshot_20160616_111131.png > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
