> On Juni 17, 2016, 5:32 nachm., Thomas Pfeiffer wrote: > > I still think that the applets need a completely different layout in order > > to really be useful in panels (who would really want to use a whole panel > > just to show CPU load?), but that's probably for another patch. > > The changes themselves look fine! > > Andreas Kainz wrote: > I don't understand the first sentence. there is the cup applet with an > diagramm mode (and some other diagramm mode plasmoids) and the system load > plasmoid where you can see what happens now. In general the diagramm mode is > for me more importend than the what's happen now. From the visual design I > like the diagrammms but I'm not happy to show the graph grid (0-line) this > would be usefull when you can have negative values but here it is not needed. > but however we will see what a future request will bring. > > waiting for a ship it from a developer. > > Thomas Pfeiffer wrote: > In Plasma 4, the system monitor plasmoids were far more narrow. > If you use e.g. the CPU monitor Plasmoid in Plasma 5, it occupies almost > your whole panel by default. Are these graphs really important enough for > anybody to occupy a whole panel with them?
the problem was when I use a smaler width the text sometimes will overlap. that's the reason of the width. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96640 ----------------------------------------------------------- On Juni 16, 2016, 12:14 nachm., Andreas Kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128136/ > ----------------------------------------------------------- > > (Updated Juni 16, 2016, 12:14 nachm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > 1. change the minimum size and the min width in the panel > 2. speedLabels are now right align to the label cause you show the number > which is drown on the right part of the diagramm > 3. round to 14 % instead of 14,14 % for cpu load > > still missing: > a. hide the heading if the desktop widget has to less space for the rows > b. better friendlyName for ram, network > c. remove the gray line from the chart (0-line) at least when the applet was > shown on the panel > d. don't show 0 KB/s or 0 B, ... > > shedule > thanks for your review > if you know how I can fix one of the missing things, let me know > tiny improvements when missing stuff is finished. > > > Diffs > ----- > > applets/systemmonitor/common/contents/ui/Applet.qml fffd8e0 > applets/systemmonitor/common/contents/ui/DoublePlotter.qml 738ffbc > applets/systemmonitor/common/contents/ui/SinglePlotter.qml 987fd2c > applets/systemmonitor/cpu/contents/ui/cpu.qml 4ebbf92 > applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml 994336f > > Diff: https://git.reviewboard.kde.org/r/128136/diff/ > > > Testing > ------- > > on the desktop and the panel > > > File Attachments > ---------------- > > screenshot of the result > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/16/4fecb3bc-d540-4358-af1d-342c77b9cfa3__Screenshot_20160616_111131.png > > > Thanks, > > Andreas Kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
