hein marked an inline comment as done. hein added a comment.
I didn't like "WithIcon" because it sounds like it guarantees handing over an icon, but it's really a fallback - so would have to be LauncherUrlWithFallbackIcon, which is quite a mouthful. I think it's prettier to have LauncherUrl to be the full thing and opt into the restrictions :) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, dfaure Cc: plasma-devel, jensreuterberg, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
