dfaure added a comment.
Maybe it should have been the other way around, LauncherUrlWithIcon where
needed ;-)
(it seems the icon is only rarely needed)
INLINE COMMENTS
> ContextMenu.qml:225
> } else {
> - tasksModel.requestAddLauncher(visualParent.launcherUrl);
> + tasksModel.requestAddLauncher(visualParent.launcherUrl());
> }
Is it expected that requestRemoveLauncher is "without icon" and
requestAddLauncher is "with icon"? Seems asymmetric but I don't know enough
about this to know if it's ok or not.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1931
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, dfaure
Cc: plasma-devel, jensreuterberg, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
