-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128108/
-----------------------------------------------------------

(Updated June 8, 2016, 10:25 p.m.)


Review request for Plasma and Friedrich W. H. Kossebau.


Changes
-------

close all issues and change additional 2 thing:

1. in the settings dialogue the busy indicator was changed.
2. opacity should be 0.6 instead of 0.5 for secondary text.

thanks for all your feedback.


Repository: kdeplasma-addons


Description
-------

the scaling work now better and the pading between the single lines can be 
smaler (If you make the applet higher you can also have the old line spacing)

it's my first qml change, so ...

on my todo, I'd like to change the powerd by weather.com text color so a 
secondary gray (bring it a bit more to the background), but I don't know how.


Diffs (updated)
-----

  applets/weather/package/contents/ui/FiveDaysView.qml 5023373 
  applets/weather/package/contents/ui/TopPanel.qml 1821f16 
  applets/weather/package/contents/ui/WeatherListView.qml c7b331e 
  applets/weather/package/contents/ui/configWeatherStation.qml 86ed521 
  applets/weather/package/contents/ui/main.qml d490728 

Diff: https://git.reviewboard.kde.org/r/128108/diff/


Testing
-------

with breeze and breeze dark color scheme on two different pc's. the icons are 
breeze weather icons (master)


File Attachments
----------------

screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/350136df-37c8-4fef-bddb-d4b609df2fb1__weather.png
I hope I had fixed all open issues. I now have only one open issue I could 
change the linkColor but I can't change the color when there is no link like in 
noaa
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/3ef83b18-d8e3-4a73-a8da-a069c56a560a__weather.png


Thanks,

Andreas Kainz

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to