> On May 10, 2016, 12:50 p.m., David Edmundson wrote: > > src/kiconloader.cpp, line 839 > > <https://git.reviewboard.kde.org/r/127875/diff/2/?file=464573#file464573line839> > > > > Aren't we missing an arg? > > > > return QStringLiteral(".ColorScheme-Text {\ > > color:%1;\ > > }\ > > .ColorScheme-Background{\ > > color:%2;\ > > }\ > > .ColorScheme-Highlight{\ > > color:%3;\ > > }\ > > .ColorScheme-PositiveText{\ > > color:%4;\ > > }\ > > .ColorScheme-NeutralText{\ > > color:%5;\ > > }\ > > .ColorScheme-NegativeText{\ > > color:%6;\ > > }"); > > > > > > == 6 > > > > this (before and after) has 5. > > > > background is missing.
proper colors are .arg ed now - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/#review95345 ----------------------------------------------------------- On May 10, 2016, 2:15 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127875/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 2:15 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kiconthemes > > > Description > ------- > > QIcon has a Selected state that wasn't mapped to KIcon, use it and in case > for svg based icons that take colors from the palette take the > highlightedText color from the palette to color the icon instead of the text > color, making it possible for styles to have white icons and white text in > selected menu items (need explicit support from the style, patches in breeze > and the like coming) > > > Diffs > ----- > > src/kiconengine.cpp 7c72ade > src/kiconloader.h cf2f58a > src/kiconloader.cpp 01d0a8d > > Diff: https://git.reviewboard.kde.org/r/127875/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > menu.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
