----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ -----------------------------------------------------------
(Updated May 10, 2016, 2:15 p.m.) Review request for KDE Frameworks and Plasma. Repository: kiconthemes Description ------- QIcon has a Selected state that wasn't mapped to KIcon, use it and in case for svg based icons that take colors from the palette take the highlightedText color from the palette to color the icon instead of the text color, making it possible for styles to have white icons and white text in selected menu items (need explicit support from the style, patches in breeze and the like coming) Diffs (updated) ----- src/kiconengine.cpp 7c72ade src/kiconloader.h cf2f58a src/kiconloader.cpp 01d0a8d Diff: https://git.reviewboard.kde.org/r/127875/diff/ Testing ------- File Attachments ---------------- menu.png https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png Thanks, Marco Martin
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel