-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/#review94185
-----------------------------------------------------------
still wondering about if it could make sense having instead
svg->setImagePath("icons/48/konversation.svg");
I may make a patch using that approach as well
- Marco Martin
On April 1, 2016, 1:19 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127260/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 1:19 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> this attempts to cache as well svg icons from the icon theme (invalidating as
> well when the icon theme is updated)
>
> still to be done, to figure out to invalidate cache when the icon theme is
> changed in the two cases:
> * theme changed with plasmashell running
> * theme changed with plasma shell not running
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt d475ac3
> src/plasma/private/theme_p.h 69a8934
> src/plasma/private/theme_p.cpp 98bccab
> src/plasma/svg.cpp 6c9c75c
>
> Diff: https://git.reviewboard.kde.org/r/127260/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel
