> On March 31, 2016, 3:34 p.m., David Edmundson wrote: > > autotests/themetest.cpp, line 71 > > <https://git.reviewboard.kde.org/r/127260/diff/3/?file=454841#file454841line71> > > > > We need to test the cache aspect of everything, as that's really the > > entire point. > > > > > > it looks like we can access it with > > > > m_svg->theme()->findInCache() to check things if icons were actually > > being inserted. > > > > and then we can test that the cache *doesn't* contain an entry after > > the spy finishes. > > > > I made a patch: > > https://paste.kde.org/pgyzgxmzv > > > > > > > > From what I can tell, it doesn't work. Though that's possibly my part > > new lines? > > Marco Martin wrote: > yeah, the patch doesn't work for me as well, looking into it
ah, right, the key id is based on the path, but is not the path, is from SvgPrivate::cachePath() that is not accessible from outside - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review94156 ----------------------------------------------------------- On March 31, 2016, 1:07 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127260/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 1:07 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this attempts to cache as well svg icons from the icon theme (invalidating as > well when the icon theme is updated) > > still to be done, to figure out to invalidate cache when the icon theme is > changed in the two cases: > * theme changed with plasmashell running > * theme changed with plasma shell not running > > > Diffs > ----- > > autotests/CMakeLists.txt d475ac3 > > autotests/data/icons/test-theme-two/apps/22/tst-plasma-framework-test-icon.svg > PRE-CREATION > autotests/data/icons/test-theme-two/index.theme PRE-CREATION > autotests/themetest.h PRE-CREATION > autotests/themetest.cpp PRE-CREATION > src/plasma/private/theme_p.h 69a8934 > src/plasma/private/theme_p.cpp 98bccab > src/plasma/svg.cpp 6c9c75c > > Diff: https://git.reviewboard.kde.org/r/127260/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
